]> git.proxmox.com Git - mirror_qemu.git/commit - net/net.c
QemuOpts: Drop qemu_opts_foreach() parameter abort_on_failure
authorMarkus Armbruster <armbru@redhat.com>
Fri, 13 Mar 2015 10:07:24 +0000 (11:07 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Mon, 8 Jun 2015 17:33:20 +0000 (19:33 +0200)
commita4c7367f7dd9348f94dc4298571ed515b8160a27
treec2b07e89034639213052178832ed3b1e24bb4ac7
parent8122928a52248e28513c79d9b9929c6d20c866ea
QemuOpts: Drop qemu_opts_foreach() parameter abort_on_failure

When the argument is non-zero, qemu_opts_foreach() stops on callback
returning non-zero, and returns that value.

When the argument is zero, it doesn't stop, and returns the bit-wise
inclusive or of all the return values.  Funky :)

The callers that pass zero could just as well pass one, because their
callbacks can't return anything but zero:

* qemu_add_globals()'s callback qdev_add_one_global()

* qemu_config_write()'s callback config_write_opts()

* main()'s callbacks default_driver_check(), drive_enable_snapshot(),
  vnc_init_func()

Drop the parameter, and always stop.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
block/blkdebug.c
hw/core/qdev-properties-system.c
include/qemu/option.h
net/net.c
net/vhost-user.c
numa.c
tpm.c
util/qemu-config.c
util/qemu-option.c
vl.c