]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit - net/sctp/debug.c
net: sctp: fix array overrun read on sctp_timer_tbl
authorColin Ian King <colin.king@canonical.com>
Tue, 24 Jan 2017 09:25:54 +0000 (09:25 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 24 Jan 2017 20:24:35 +0000 (15:24 -0500)
commit146408693945a68f227175c1cea3772fc0f98f20
tree36aab7f9a1e6bc0b7bc7dda4baf8bd566d852dba
parent7110fe471efb0160f89dbcb58251bd69842ceba1
net: sctp: fix array overrun read on sctp_timer_tbl

Table sctp_timer_tbl is missing a TIMEOUT_RECONF string so
add this in. Also compare timeout with the size of the array
sctp_timer_tbl rather than SCTP_EVENT_TIMEOUT_MAX.  Also add
a build time check that SCTP_EVENT_TIMEOUT_MAX is correct
so we don't ever get this kind of mismatch between the table
and SCTP_EVENT_TIMEOUT_MAX in the future.

Kudos to Marcelo Ricardo Leitner for spotting the missing string
and suggesting the build time sanity check.

Fixes CoverityScan CID#1397639 ("Out-of-bounds read")

Fixes: 7b9438de0cd4 ("sctp: add stream reconf timer")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/debug.c