]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit - net/tipc/socket.c
tipc: orphan sock in tipc_release()
authorCong Wang <xiyou.wangcong@gmail.com>
Tue, 4 Sep 2018 02:12:41 +0000 (19:12 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Sep 2018 05:14:00 +0000 (22:14 -0700)
commit0a3b8b2b215f9e84b82ae97df71292ccfd92b1e7
tree8dcd50c6f0a21d53352fc53dc828ebb8a180dc27
parente65a9e480e91ddf9e15155454d370cead64689c8
tipc: orphan sock in tipc_release()

Before we unlock the sock in tipc_release(), we have to
detach sk->sk_socket from sk, otherwise a parallel
tipc_sk_fill_sock_diag() could stil read it after we
free this socket.

Fixes: c30b70deb5f4 ("tipc: implement socket diagnostics for AF_TIPC")
Reported-and-tested-by: syzbot+48804b87c16588ad491d@syzkaller.appspotmail.com
Cc: Jon Maloy <jon.maloy@ericsson.com>
Cc: Ying Xue <ying.xue@windriver.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/socket.c