]> git.proxmox.com Git - mirror_ovs.git/commit - ofproto/bundles.c
ofp-errors: Send as much of a message as possible in an error reply.
authorBen Pfaff <blp@ovn.org>
Tue, 9 Jan 2018 18:38:31 +0000 (10:38 -0800)
committerBen Pfaff <blp@ovn.org>
Tue, 9 Jan 2018 18:38:34 +0000 (10:38 -0800)
commit52c57cbb64dff46502be5bb88c2c08aa1571083d
tree61aca2ab0fd8a442b0f8137e187018a04dc06fbd
parentf59cb331c481d08f9a851c07cf31e9d826650485
ofp-errors: Send as much of a message as possible in an error reply.

When an OpenFlow switch sends an error message in reply to a request
from a controller, it includes an excerpt from the original request.  The
OpenFlow specification only requires the switch to send at least the first
64 bytes of the request.  Until now, Open vSwitch has only sent that much.
This commit changes Open vSwitch to instead send the entire message, only
trimming it if necessary to keep the error message within the 64 kB limit
for an OpenFlow message.  This should simplify debugging for controller
authors.

CC: Suneel Bomminayuni <sbomminayuni@vmware.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
Acked-by: Justin Pettit <jpettit@ovn.org>
lib/ofp-errors.c
ofproto/bundles.c
ofproto/bundles.h
ofproto/connmgr.c
ofproto/connmgr.h
ofproto/ofproto.c
tests/ofproto.at