]> git.proxmox.com Git - mirror_qemu.git/commit - python/qemu/machine/machine.py
python/machine: remove has_quit argument
authorJohn Snow <jsnow@redhat.com>
Tue, 26 Oct 2021 17:56:05 +0000 (13:56 -0400)
committerJohn Snow <jsnow@redhat.com>
Mon, 1 Nov 2021 15:54:59 +0000 (11:54 -0400)
commitb9420e4f4b899c96221fa5a1f7f025214e756c50
treebf744d81f87511a55c776f29e94ac89e4525a28b
parent461044ceb4fe58eb919dedfeb62f619f79d4d552
python/machine: remove has_quit argument

If we spy on the QMP commands instead, we don't need callers to remember
to pass it. Seems like a fair trade-off.

The one slightly weird bit is overloading this instance variable for
wait(), where we use it to mean "don't issue the qmp 'quit'
command". This means that wait() will "fail" if the QEMU process does
not terminate of its own accord.

In most cases, we probably did already actually issue quit -- some
iotests do this -- but in some others, we may be waiting for QEMU to
terminate for some other reason, such as a test wherein we tell the
guest (directly) to shut down.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-id: 20211026175612.4127598-2-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
python/qemu/machine/machine.py
tests/qemu-iotests/040
tests/qemu-iotests/218
tests/qemu-iotests/255