]> git.proxmox.com Git - mirror_qemu.git/commit - qapi/migration.json
qapi: add conditions to REPLICATION type/commands on the schema
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Thu, 13 Dec 2018 12:37:24 +0000 (16:37 +0400)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 14 Dec 2018 05:52:48 +0000 (06:52 +0100)
commit335d10cd8e2c3bb6067804b095aaf6371fc1983e
treed28aa8a7ab7be1fa19de600e94f98e05b676790d
parentfd9dda3b7091ec1dcd461f2ad054ab96768324f3
qapi: add conditions to REPLICATION type/commands on the schema

Add #if defined(CONFIG_REPLICATION) in generated code, and adjust the
code accordingly.

Made conditional:

* xen-set-replication, query-xen-replication-status,
  xen-colo-do-checkpoint

  Before the patch, we first register the commands unconditionally in
  generated code (requires a stub), then conditionally unregister in
  qmp_unregister_commands_hack().

  Afterwards, we register only when CONFIG_REPLICATION.  The command
  fails exactly the same, with CommandNotFound.

  Improvement, because now query-qmp-schema is accurate, and we're one
  step closer to killing qmp_unregister_commands_hack().

* enum BlockdevDriver value "replication" in command blockdev-add

* BlockdevOptions variant @replication

and related structures.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20181213123724.4866-23-marcandre.lureau@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
migration/colo.c
monitor.c
qapi/block-core.json
qapi/migration.json