]> git.proxmox.com Git - mirror_qemu.git/commit - qapi/misc.json
qmp: 'add_client' actually expects sockets
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Mon, 6 Mar 2023 12:27:45 +0000 (16:27 +0400)
committerMarc-André Lureau <marcandre.lureau@redhat.com>
Mon, 13 Mar 2023 11:40:41 +0000 (15:40 +0400)
commitbf5de8c5d66552721fefe08de849c115ca366b56
treeb03ab6660003d38914e76f39d660fe80d8e29c90
parent0a237f4de45b8addbc35a316ee1c0bc7a4887da7
qmp: 'add_client' actually expects sockets

Whether it is SPICE, VNC, D-Bus, or the socket chardev, they all
actually expect a socket kind or will fail in different ways at runtime.

Throw an error early if the given 'add_client' fd is not a socket, and
close it to avoid leaks.

This allows to replace the close() call with a more correct & portable
closesocket() version.

(this will allow importing sockets on Windows with a specialized command
in the following patch, while keeping the remaining monitor associated
sockets/add_client code & usage untouched)

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230306122751.2355515-6-marcandre.lureau@redhat.com>
monitor/qmp-cmds.c
qapi/misc.json