]> git.proxmox.com Git - mirror_qemu.git/commit - qapi/string-input-visitor.c
qapi: Make string input and opts visitor require non-null input
authorMarkus Armbruster <armbru@redhat.com>
Fri, 3 Mar 2017 12:32:36 +0000 (13:32 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Sun, 5 Mar 2017 08:14:19 +0000 (09:14 +0100)
commitf332e830e38b3ff3953ef02ac04e409ae53769c5
tree6b97a4198f04510aa7d12a3754a40fe9b99d185a
parenta8aec6de2ac1a5e36989fdfba29067b361009b75
qapi: Make string input and opts visitor require non-null input

The string input visitor tries to cope with null input.  Null input
isn't used anywhere, and isn't covered by tests.  Unsurprisingly, it
doesn't fully work: start_list() crashes because it passes the input
via parse_str() to strtoll() unchecked.

Make string_input_visitor_new() assert its argument isn't null, and
drop the code trying to deal with null input.

The opts visitor crashes when you try to actually visit something with
null input.  Make opts_visitor_new() assert its argument isn't null,
mostly for clarity.

qobject_input_visitor_new() already asserts its argument isn't null.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <1488544368-30622-17-git-send-email-armbru@redhat.com>
qapi/opts-visitor.c
qapi/string-input-visitor.c