]> git.proxmox.com Git - mirror_qemu.git/commit - qemu-char.c
qemu-char: Fix ID reuse after chardev-remove for qapi-based init
authorMarkus Armbruster <armbru@redhat.com>
Thu, 27 Jun 2013 13:25:12 +0000 (15:25 +0200)
committerAnthony Liguori <aliguori@us.ibm.com>
Fri, 28 Jun 2013 19:04:00 +0000 (14:04 -0500)
commit2ea3e2c1e85097c45a882dbc1fbba4a7fdb3ff1c
tree4f51836aed2df106b95320ec3ecb113a126db2de
parent43f420f8419866619bd107d5ee84c727b46967b8
qemu-char: Fix ID reuse after chardev-remove for qapi-based init

Commit 2c5f488 introduced qapi-based character device initialization
as a new code path in qemu_chr_new_from_opts().  Unfortunately, it
failed to store parameter opts in the new chardev.  Therefore,
qemu_chr_delete() doesn't delete it.  Even though the device is gone,
its options linger, and any attempt to create another one with the
same ID fails.

Cc: qemu-stable@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 1372339512-28149-1-git-send-email-armbru@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
qemu-char.c