]> git.proxmox.com Git - qemu.git/commit - qemu-char.c
qemu-char: Set foo_tag = 0 when returning FALSE from callbacks
authorHans de Goede <hdegoede@redhat.com>
Thu, 25 Apr 2013 11:53:02 +0000 (13:53 +0200)
committerAnthony Liguori <aliguori@us.ibm.com>
Thu, 25 Apr 2013 19:45:47 +0000 (14:45 -0500)
commit79f2007578a0a205e25a6f299cc52d6732337089
treea5f6c8c3d6e8f91a1d9c4bc83fe655662b3537d2
parente4dcd8ace175a1a6bfb8945d8ae1906be051b36b
qemu-char: Set foo_tag = 0 when returning FALSE from callbacks

While reviewing some patches I found this problem where tcp_chr_accept
does not clear listen_tag when returning FALSE, leading to a double
g_source_remove of the underlying source. Not really a problem unless the id
gets re-used in between, but still something we should fix.

While at it I've also reviewed all the other code in qemu-char.c for
similar problems and found that pty_chr_timer has the same problem.

Cc: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Message-id: 1366890782-10311-1-git-send-email-hdegoede@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
qemu-char.c