]> git.proxmox.com Git - mirror_qemu.git/commit - qemu-img.c
qemu-img: Use user_creatable_process_cmdline() for --object
authorKevin Wolf <kwolf@redhat.com>
Wed, 17 Feb 2021 11:56:45 +0000 (12:56 +0100)
committerKevin Wolf <kwolf@redhat.com>
Fri, 19 Mar 2021 09:17:14 +0000 (10:17 +0100)
commit99b1e64688893d0b772074b5a2972a0bad85c19f
tree99c8c884708cf8766dba48cfd8b9a96aaf42570f
parentffd58ef88c73700113e0808e8222ef4d22224f33
qemu-img: Use user_creatable_process_cmdline() for --object

This switches qemu-img from a QemuOpts-based parser for --object to
user_creatable_process_cmdline() which uses a keyval parser and enforces
the QAPI schema.

Apart from being a cleanup, this makes non-scalar properties accessible.

As a side effect, fix wrong exit codes in the object parsing error path
of 'qemu-img compare'. This was broken in commit 334c43e2c3 because
&error_fatal exits with an exit code of 1, while it should have been 2.

Document that exit code 0 is also returned when just requested help was
printed instead of comparing images. This is preexisting behaviour that
isn't changed by this patch, though another instance of it is added with
'--object help'.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
docs/tools/qemu-img.rst
qemu-img.c