]> git.proxmox.com Git - mirror_qemu.git/commit - qga/commands-posix.c
qga: Use return values instead of error_is_set(errp)
authorMarkus Armbruster <armbru@redhat.com>
Fri, 2 May 2014 11:26:33 +0000 (13:26 +0200)
committerLuiz Capitulino <lcapitulino@redhat.com>
Fri, 9 May 2014 13:11:30 +0000 (09:11 -0400)
commita903f40c314c57734ffd651786c953541cfc43a8
treeea78f1fda3a04c5fa166c136b470d7ee65563fc4
parent64dfefed169465c5d0fc20fda7b06104406e390c
qga: Use return values instead of error_is_set(errp)

Using error_is_set(errp) to check whether a function call failed is
fragile: it breaks when errp is null.  ga_get_fd_handle() and
guest_file_handle_add() don't return a useful value when they fail,
but that's just stupid.  Fix that, and check them instead.  As far
as I can tell, errp can't be null there, but this is more robust and
more obviously correct.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
qga/commands-posix.c
qga/main.c