]> git.proxmox.com Git - mirror_qemu.git/commit - qga/commands-win32.c
qga-win: Fix guest-get-devices error API violations
authorMarkus Armbruster <armbru@redhat.com>
Wed, 21 Oct 2020 07:15:19 +0000 (09:15 +0200)
committerMichael Roth <michael.roth@amd.com>
Mon, 2 Nov 2020 14:14:36 +0000 (08:14 -0600)
commit939caddc2c24a9f4840e5d9d52eb0465deed1c47
tree10ce768041a647adc9bbd11d56418e7f1ec6ba67
parenta88bceef789f0b8bfe96bb77cef686e9b4976699
qga-win: Fix guest-get-devices error API violations

The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL.  Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.

qmp_guest_get_devices() is wrong that way: it calls error_setg() in a
loop.

If no iteration fails, the function returns a value and sets no error.
Okay.

If exactly one iteration fails, the function returns a value and sets
an error.  Wrong.

If multiple iterations fail, the function trips error_setv()'s
assertion.

Fix it to return immediately on error.

Perhaps the failure to convert the driver version to UTF-8 should not
be an error.  We could simply not report the botched version string
instead.

Drop a superfluous continue while there.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Michael Roth <michael.roth@amd.com>
qga/commands-win32.c