]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - security/selinux/hooks.c
signals: don't abuse __flush_signals() in selinux_bprm_committed_creds()
authorOleg Nesterov <oleg@redhat.com>
Thu, 4 Jun 2015 20:22:16 +0000 (16:22 -0400)
committerPaul Moore <pmoore@redhat.com>
Thu, 4 Jun 2015 20:22:16 +0000 (16:22 -0400)
commit9e7c8f8c62c1e1cda203b5bfaba4575b141e42e7
treeffbe4be8b34649fd07898137aeb74404f4fa093f
parentcded3fffbeab777e6ad2ec05d4a3b62c5caca0f3
signals: don't abuse __flush_signals() in selinux_bprm_committed_creds()

selinux_bprm_committed_creds()->__flush_signals() is not right, we
shouldn't clear TIF_SIGPENDING unconditionally. There can be other
reasons for signal_pending(): freezing(), JOBCTL_PENDING_MASK, and
potentially more.

Also change this code to check fatal_signal_pending() rather than
SIGNAL_GROUP_EXIT, it looks a bit better.

Now we can kill __flush_signals() before it finds another buggy user.

Note: this code looks racy, we can flush a signal which was sent after
the task SID has been updated.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Paul Moore <pmoore@redhat.com>
include/linux/sched.h
kernel/signal.c
security/selinux/hooks.c