]> git.proxmox.com Git - mirror_qemu.git/commit - softmmu/vl.c
vnc: Clean up error reporting in vnc_init_func()
authorMarkus Armbruster <armbru@redhat.com>
Wed, 17 Oct 2018 08:26:51 +0000 (10:26 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 19 Oct 2018 12:51:34 +0000 (14:51 +0200)
commit612aea201738cd747b02d2c2acd6e0bf406531cf
tree1f000723c45e1d0a5c4ef19c42e34b68417bab0e
parentab4f931e9f0a6e1c6dd6ecd79118efca418d941f
vnc: Clean up error reporting in vnc_init_func()

Calling error_report() in a function that takes an Error ** argument
is suspicious.  vnc_init_func() does that, and then fails without
setting an error.  Its caller main(), via qemu_opts_foreach(), is fine
with it, but clean it up anyway.

While there, drop a "Failed to start VNC server: " error message
prefix that doesn't really add value.

Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20181017082702.5581-28-armbru@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
ui/vnc.c
vl.c