]> git.proxmox.com Git - mirror_qemu.git/commit - softmmu/vl.c
qom: Change object property iterator API contract
authorDaniel P. Berrange <berrange@redhat.com>
Wed, 9 Dec 2015 12:34:02 +0000 (12:34 +0000)
committerAndreas Färber <afaerber@suse.de>
Mon, 18 Jan 2016 16:47:58 +0000 (17:47 +0100)
commit7746abd8e9ee9db20c0b0fdb19504f163ba3cbea
treea5e9c56a0342b23cabe21e6bd199f312e1393fab
parent16bf7f522a2ff68993f80631ed86254c71eaf5d4
qom: Change object property iterator API contract

Currently the ObjectProperty iterator API works as follows:

  ObjectPropertyIterator *iter;

  iter = object_property_iter_init(obj);
  while ((prop = object_property_iter_next(iter))) {
     ...
  }
  object_property_iter_free(iter);

This has the benefit that the ObjectPropertyIterator struct
can be opaque, but has the downside that callers need to
explicitly call a free function. It is also not in keeping
with iterator style used elsewhere in QEMU/GLib2.

This patch changes the API to use stack allocation instead:

  ObjectPropertyIterator iter;

  object_property_iter_init(&iter, obj);
  while ((prop = object_property_iter_next(&iter))) {
     ...
  }

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[AF: Fused ObjectPropertyIterator struct with typedef]
Signed-off-by: Andreas Färber <afaerber@suse.de>
hw/ppc/spapr_drc.c
include/qom/object.h
net/filter.c
qmp.c
qom/object.c
tests/check-qom-proplist.c
vl.c