]> git.proxmox.com Git - libgit2.git/commit - src/libgit2/repository.c
Redesigned the walking/object lookup interface
authorVicent Marti <tanoku@gmail.com>
Sun, 8 Aug 2010 12:12:17 +0000 (14:12 +0200)
committerVicent Marti <tanoku@gmail.com>
Thu, 12 Aug 2010 16:48:55 +0000 (18:48 +0200)
commit3315782cb4f2b683c66a53c93aa81de501c5a4ab
treee3fa8b56dc17b749cc53520eb350cbcc46101007
parentf8758044876b30b0f6482d1fe8c3b1de743f4186
Redesigned the walking/object lookup interface

The old 'git_revpool' object has been removed and
split into two distinct objects with separate
functionality, in order to have separate methods for
object management and object walking.

* A new object 'git_repository' does the high-level
management of a repository's objects (commits, trees,
tags, etc) on top of a 'git_odb'.

Eventually, it will also manage other repository
attributes (e.g. tag resolution, references, etc).

See: src/git/repository.h

* A new external method
'git_repository_lookup(repo, oid, type)'
has been added to the 'git_repository' API.

All object lookups (git_XXX_lookup()) are now
wrappers to this method, and duplicated code
has been removed. The method does automatic type
checking and returns a generic 'git_revpool_object'
that can be cast to any specific object.

See: src/git/repository.h

* The external methods for object parsing of repository
objects (git_XXX_parse()) have been removed.

Loading objects from the repository is now managed
through the 'lookup' functions. These objects are
loaded with minimal information, and the relevant
parsing is done automatically when the user requests
any of the parsed attributes through accessor methods.

An attribute has been added to 'git_repository' in
order to force the parsing of all the repository objects
immediately after lookup.

See: src/git/commit.h
See: src/git/tag.h
See: src/git/tree.h

* The previous walking functionality of the revpool
is now found in 'git_revwalk', which does the actual
revision walking on a repository; the attributes
when walking through commits in a database have been
decoupled from the actual commit objects.
This increases performance when accessing commits
during the walk and allows to have several
'git_revwalk' instances working at the same time on
top of the same repository, without having to load
commits in memory several times.

See: src/git/revwalk.h

* The old 'git_revpool_table' has been renamed to
'git_hashtable' and now works as a generic hashtable
with support for any kind of object and custom hash
functions.

See: src/hashtable.h

* All the relevant unit tests have been updated, renamed
and grouped accordingly.

Signed-off-by: Vicent Marti <tanoku@gmail.com>
30 files changed:
src/commit.c
src/commit.h
src/git/commit.h
src/git/common.h
src/git/odb.h
src/git/repository.h [new file with mode: 0644]
src/git/revwalk.h
src/git/tag.h
src/git/tree.h
src/hashtable.c [new file with mode: 0644]
src/hashtable.h [new file with mode: 0644]
src/repository.c [new file with mode: 0644]
src/repository.h [new file with mode: 0644]
src/revobject.c [deleted file]
src/revobject.h [deleted file]
src/revwalk.c
src/revwalk.h
src/tag.c
src/tag.h
src/tree.c
src/tree.h
tests/t0401-parse.c
tests/t0402-details.c
tests/t0403-lists.c [deleted file]
tests/t0501-walk.c
tests/t0502-list.c [new file with mode: 0644]
tests/t0502-table.c [deleted file]
tests/t0503-tableit.c [deleted file]
tests/t0701-table.c [new file with mode: 0644]
tests/t0702-tableit.c [new file with mode: 0644]