]> git.proxmox.com Git - mirror_lxc.git/commit - src/lxc/start.c
valgrind drd tool shows conflicting stores happening at lxc_global_config_value@src...
authorS.Çağlar Onur <caglar@10ur.org>
Fri, 1 Nov 2013 20:16:10 +0000 (16:16 -0400)
committerSerge Hallyn <serge.hallyn@ubuntu.com>
Fri, 1 Nov 2013 21:40:00 +0000 (16:40 -0500)
commit052616ebc639aa865c9da3805227cd46618346b6
tree602de34ad7ebfcead2f5826579ae931100cf5be8
parent4de2791fa7dcc6d4cd445f3c6678623a998b18e2
valgrind drd tool shows conflicting stores happening at lxc_global_config_value@src/lxc/utils.c (v2)

Conflict occurs between following lines

[...]
269         if (values[i])
270                 return values[i];
[...]

and

[...]
309         /* could not find value, use default */
310         values[i] = (*ptr)[1];
[...]

fix it using a specific lock dedicated to that problem as Serge suggested.

Also introduce a new autoconf parameter (--enable-mutex-debugging) to convert mutexes to error reporting type and to provide a stacktrace when locking fails.

Signed-off-by: S.Çağlar Onur <caglar@10ur.org>
Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
configure.ac
src/lxc/cgroup.c
src/lxc/lxclock.c
src/lxc/start.c
src/lxc/utils.c
src/lxc/utils.h