]> git.proxmox.com Git - mirror_qemu.git/commit - system/physmem.c
softmmu/physmem: Fix ram_block_discard_range() to handle shared anonymous memory
authorDavid Hildenbrand <david@redhat.com>
Tue, 6 Apr 2021 08:01:25 +0000 (10:01 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 15 Jun 2021 18:27:37 +0000 (20:27 +0200)
commitcdfa56c551bb48f286cfe1f2daa1083d333ee45d
treec033cf1a1fe6a82ef2a42c4de4dea8a94652cd18
parent7ce18ca0257dac6e3ac92c8bc3d610abbf14bcce
softmmu/physmem: Fix ram_block_discard_range() to handle shared anonymous memory

We can create shared anonymous memory via
    "-object memory-backend-ram,share=on,..."
which is, for example, required by PVRDMA for mremap() to work.

Shared anonymous memory is weird, though. Instead of MADV_DONTNEED, we
have to use MADV_REMOVE: MADV_DONTNEED will only remove / zap all
relevant page table entries of the current process, the backend storage
will not get removed, resulting in no reduced memory consumption and
a repopulation of previous content on next access.

Shared anonymous memory is internally really just shmem, but without a
fd exposed. As we cannot use fallocate() without the fd to discard the
backing storage, MADV_REMOVE gets the same job done without a fd as
documented in "man 2 madvise". Removing backing storage implicitly
invalidates all page table entries with relevant mappings - an additional
MADV_DONTNEED is not required.

Fixes: 06329ccecfa0 ("mem: add share parameter to memory-backend-ram")
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20210406080126.24010-3-david@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
include/qemu/osdep.h
softmmu/physmem.c