]> git.proxmox.com Git - mirror_ovs.git/commit - tests/ovn.at
ovn-northd: Fix peering of routers.
authorGurucharan Shetty <guru@ovn.org>
Sun, 27 Mar 2016 13:25:57 +0000 (06:25 -0700)
committerGurucharan Shetty <guru@ovn.org>
Fri, 1 Apr 2016 16:57:55 +0000 (09:57 -0700)
commit509afdc3df6b256d44f74068ad559c9ff0afc17e
treeabb6945a30fc64016f071484b3760998ef9e3528
parent8a568f743b0e6713f29e30b974093f03a9ace8d3
ovn-northd: Fix peering of routers.

1. Currently, the ovn-nb man page says that the 'peer'
in a logical_router_port table should point to the name
of the peer's logical router port. But the schema had declared
this column as a uuid. This looks not to be the intention as peers
for logical switches connected to routers is a name (and not a uuid).
So this patch changes the schema to be name.

2. In the southbound database, in the port_binding table, for a
logical_router_port, the peer was pointing back to itself. This
was causing ovn-controller to create patch ports where the peer
was wrongly pointing back to the source itself. This clearly looks
to be an error. So this patch fixes the peer in southbound database
to correclty point to the real peer.

3. ovn-northd.c currently skips generating logical flows to transfer
packets between two peers with comment about needing 'ARP for
neighboring routers'. It looked to me that since the router peer
is a logical object that has to be created in OVN-NB database, we
always need to statically assign the mac address. So this patch
picks the mac address from the database.

Signed-off-by: Gurucharan Shetty <guru@ovn.org>
Acked-by: Ben Pfaff <blp@ovn.org>
Acked-by: Ryan Moats <rmoats@us.ibm.com>
ovn/northd/ovn-northd.8.xml
ovn/northd/ovn-northd.c
ovn/ovn-nb.ovsschema
tests/ovn.at