]> git.proxmox.com Git - mirror_ovs.git/commit - tests/ovn.at
ovn-northd: Sort options in put_dhcp(v6)_opts.
authorDaniele Di Proietto <diproiettod@vmware.com>
Fri, 9 Dec 2016 01:43:31 +0000 (17:43 -0800)
committerDaniele Di Proietto <diproiettod@vmware.com>
Tue, 13 Dec 2016 01:25:47 +0000 (17:25 -0800)
commit7c76bf4e0e2787b89a84302233918fa04043a969
tree51f371b983751093ae194cb51ae852ef8ca59a15
parent06ca9597a63ea109d1e66ba09c9a28b56f9df6c9
ovn-northd: Sort options in put_dhcp(v6)_opts.

The order of the options in the packet generated by ovs-controller
depends on the hash function.  I believe that murmur hash (our default)
produces different outputs depending on the endianness of the system.
Also, if SSE4.2 is enabled at build time, we use CRC32 for hashing which
gives different results even on x86.

This causes one unit test to fail on big endian or with SSE4.2:

ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS

This commit fixes the problem in ovn-northd by always sorting dhcp
options inside the logical flow put_dhcp(v6)_opts action.

Reported-at: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=840770
Suggested-by: Ben Pfaff <blp@ovn.org>
Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com>
Acked-by: Ben Pfaff <blp@ovn.org>
ovn/northd/ovn-northd.c
tests/ovn.at