]> git.proxmox.com Git - mirror_qemu.git/commit - tests/qtest/drive_del-test.c
libqtest: Remove qtest_qmp_discard_response() & friends
authorMarkus Armbruster <armbru@redhat.com>
Mon, 6 Aug 2018 06:53:25 +0000 (08:53 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 16 Aug 2018 06:42:06 +0000 (08:42 +0200)
commit055a1efc7c5a30ca0993720da57ba70179d28c7b
treea64a16a0cf3cc6e3f1f8dff8289b20d6b10549d6
parentbe62e1724f383c9e5012732af6c4dce587a917ee
libqtest: Remove qtest_qmp_discard_response() & friends

qtest_qmp_discard_response(...) is shorthand for
qobject_unref(qtest_qmp(...), except it's not actually shorter.
Moreover, the presence of these functions encourage sloppy testing.
Remove them from libqtest.  Add them as macros to the tests that use
them, with a TODO comment asking for cleanup.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20180806065344.7103-5-armbru@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
tests/ahci-test.c
tests/boot-order-test.c
tests/drive_del-test.c
tests/fdc-test.c
tests/ide-test.c
tests/libqtest.c
tests/libqtest.h
tests/migration-test.c
tests/test-filter-mirror.c
tests/test-filter-redirector.c
tests/virtio-blk-test.c