]> git.proxmox.com Git - mirror_qemu.git/commit - tests/test-io-channel-tls.c
tests: use error_abort in places expecting errors
authorDaniel P. Berrangé <berrange@redhat.com>
Wed, 18 Jul 2018 09:06:43 +0000 (10:06 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Tue, 24 Jul 2018 16:35:57 +0000 (17:35 +0100)
commit68db13183f2d3193476f5d5457c47fa10ba0f9e3
tree06e568c5182064e52ceac4f2b44370876e240085
parent977a7204ab69a3591c4c6ed698abb8a6ee673679
tests: use error_abort in places expecting errors

Most of the TLS related tests are passing an in a "Error" object to
methods that are expected to fail, but then ignoring any error that is
set and instead asserting on a return value. This means that when an
error is unexpectedly raised, no information about it is printed out,
making failures hard to diagnose. Changing these tests to pass in
&error_abort will make unexpected failures print messages to stderr.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
tests/test-crypto-tlscredsx509.c
tests/test-crypto-tlssession.c
tests/test-io-channel-tls.c