]> git.proxmox.com Git - mirror_qemu.git/commit - tests/test-qobject-input-visitor.c
qapi script: do not allow string discriminator
authorWenchao Xia <wenchaoqemu@gmail.com>
Wed, 5 Mar 2014 02:44:39 +0000 (18:44 -0800)
committerLuiz Capitulino <lcapitulino@redhat.com>
Tue, 11 Mar 2014 13:07:42 +0000 (09:07 -0400)
commit5223070c47c6fc35ee000b2392ae76d9fab54f16
tree52a971bbbc5db95b1ebaa064483eeb6ee54ecaeb
parent59ca664ef86c8a9078157336b566e832fc5466e2
qapi script: do not allow string discriminator

Since enum based discriminators provide better type-safety and
ensure that future qapi additions do not forget to adjust dependent
unions, forbid using string as discriminator from now on.

Signed-off-by: Wenchao Xia <wenchaoqemu@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
12 files changed:
docs/qapi-code-gen.txt
scripts/qapi.py
tests/Makefile
tests/qapi-schema/flat-union-string-discriminator.err [new file with mode: 0644]
tests/qapi-schema/flat-union-string-discriminator.exit [new file with mode: 0644]
tests/qapi-schema/flat-union-string-discriminator.json [new file with mode: 0644]
tests/qapi-schema/flat-union-string-discriminator.out [new file with mode: 0644]
tests/qapi-schema/qapi-schema-test.json
tests/qapi-schema/qapi-schema-test.out
tests/test-qmp-input-strict.c
tests/test-qmp-input-visitor.c
tests/test-qmp-output-visitor.c