]> git.proxmox.com Git - mirror_qemu.git/commit - tests/test-qobject-input-visitor.c
qapi: Simplify error cleanup in test-qmp-*
authorEric Blake <eblake@redhat.com>
Fri, 6 Nov 2015 06:35:31 +0000 (23:35 -0700)
committerMarkus Armbruster <armbru@redhat.com>
Tue, 10 Nov 2015 07:08:21 +0000 (08:08 +0100)
commita12a5a1a0132527afe87c079e4aae4aad372bd94
tree5338234400f554e439fc3566364b53fa08f65ab5
parent3f66f764ee25f10d3e1144ebc057a949421b7728
qapi: Simplify error cleanup in test-qmp-*

We have several tests that perform multiple sub-actions that are
expected to fail.  Asserting that an error occurred, then clearing
it up to prepare for the next action, turned into enough
boilerplate that it was sometimes forgotten (for example, a number
of tests added to test-qmp-input-visitor.c in d88f5fd leaked err).
Worse, if an error is not reset to NULL, we risk invalidating
later use of that error (passing a non-NULL err into a function
is generally a bad idea).  Encapsulate the boilerplate into a
single helper function error_free_or_abort(), and consistently
use it.

The new function is added into error.c for use everywhere,
although it is anticipated that testsuites will be the main
client.

Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
include/qapi/error.h
tests/test-qmp-commands.c
tests/test-qmp-input-strict.c
tests/test-qmp-input-visitor.c
util/error.c