]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit - tools/perf/builtin-script.c
perf script: Use readdir() instead of deprecated readdir_r()
authorArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 8 Apr 2016 14:25:59 +0000 (11:25 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 8 Apr 2016 14:25:59 +0000 (11:25 -0300)
commita5e8e825bd1704c488bf6a46936aaf3b9f203d6a
treef88dbde3e079941e2f5e8819c74c945a0fde467d
parent99e87f7bb7268cf644add87130590966fd5d0d17
perf script: Use readdir() instead of deprecated readdir_r()

The readdir() function is thread safe as long as just one thread uses a
DIR, which is the case in 'perf script', so, to avoid breaking the build
with glibc-2.23.90 (upcoming 2.24), use it instead of readdir_r().

See: http://man7.org/linux/man-pages/man3/readdir.3.html

"However, in modern implementations (including the glibc implementation),
concurrent calls to readdir() that specify different directory streams
are thread-safe.  In cases where multiple threads must read from the
same directory stream, using readdir() with external synchronization is
still preferable to the use of the deprecated readdir_r(3) function."

Noticed while building on a Fedora Rawhide docker container.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-mt3xz7n2hl49ni2vx7kuq74g@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-script.c