]> git.proxmox.com Git - mirror_qemu.git/commit - ui/console.c
ui/console: fix crash when using gl context with non-gl listeners
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Mon, 14 Feb 2022 20:13:35 +0000 (00:13 +0400)
committerGerd Hoffmann <kraxel@redhat.com>
Fri, 4 Mar 2022 10:28:37 +0000 (11:28 +0100)
commita9fbce5e94d6b68ec8404f8a466fde873ba2bc73
treecd13613cfc3ffe31d1abcfa110260ace2caa093d
parent0a2a40da4fba8256bffd9abd94626106f80c3c8c
ui/console: fix crash when using gl context with non-gl listeners

The commit 7cc712e98 ("ui: dispatch GL events to all listener")
mechanically replaced the dpy_gl calls with a dispatch loop, using the
same pre-conditions. However, it didn't take into account that all
listeners do not have to implement the GL callbacks.

Add the missing pre-conditions before calling the callbacks.

Fix crash when running a GL-enabled VM with "-device virtio-gpu-gl-pci
-display egl-headless -vnc :0".

Fixes: 7cc712e98 ("ui: dispatch GL events to all listener")
Reported-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220214201337.1814787-2-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
ui/console.c