]> git.proxmox.com Git - mirror_qemu.git/commit - ui/keymaps.c
keymap: fix keyup mappings
authorGerd Hoffmann <kraxel@redhat.com>
Tue, 22 Jan 2019 09:28:14 +0000 (10:28 +0100)
committerGerd Hoffmann <kraxel@redhat.com>
Tue, 5 Feb 2019 09:45:44 +0000 (10:45 +0100)
commit19c1b9fd3dd5955893c0d3c187a4180313e9a0f1
tree39b304518869487cd9ca826b5c38c9b5fbdb6cff
parent4ed26e19d90bf5a4ea5662118ae5a2af46e61d36
keymap: fix keyup mappings

It is possible that the modifier state on keyup is different from the
modifier state on keydown.  In that case the keycode lookup can end up
with different keys in case multiple keysym -> keycode mappings exist,
because it picks the mapping depending on modifier state.

To fix that change the lookup logic for keyup events.  Instead of
looking at the modifier state check the key state and prefer a keycodes
where the key is in "down" state right now.

Fixes: abb4f2c965 keymap: consider modifier state when picking a mapping
Buglink: https://bugs.launchpad.net/bugs/1738283
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1658676
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20190122092814.14919-9-kraxel@redhat.com
ui/curses.c
ui/keymaps.c
ui/keymaps.h
ui/vnc.c