]> git.proxmox.com Git - mirror_qemu.git/commit - ui/spice-core.c
spice: avoid spice runtime assert
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Thu, 21 Feb 2019 11:06:55 +0000 (12:06 +0100)
committerGerd Hoffmann <kraxel@redhat.com>
Thu, 21 Feb 2019 13:09:17 +0000 (14:09 +0100)
commit83f7180227a4c383e00fcbc0c079805557a657c8
treec944faff2a98c8c585eb5276ec932fa6d22adb3e
parenta2dc3c8ecb5c1c5c42dec9ce76db3832a65128ac
spice: avoid spice runtime assert

The Spice server doesn't like to be started or stopped twice . It
aborts with:

(process:6191): Spice-ERROR **: 19:29:35.912: red-worker.c:623:handle_dev_start: assertion `!worker->running' failed

It's easy to avoid that situation since qemu spice_display_is_running
tracks the server state.

After the commit "spice: do not stop spice if VM is paused", it will
be possible to pause and resume the VM, and this will call
qemu_spice_display_start() twice. The easiest is to add a check for
spice_display_is_running with this patch to avoid the assert.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Tested-by: Victor Toso <victortoso@redhat.com>
Message-id: 20190221110703.5775-4-marcandre.lureau@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
ui/spice-core.c