]> git.proxmox.com Git - mirror_qemu.git/commit - ui/vnc-clipboard.c
ui/vnc-clipboard: fix inflate_buffer
authorFiona Ebner <f.ebner@proxmox.com>
Wed, 22 Nov 2023 12:58:26 +0000 (13:58 +0100)
committerMarc-André Lureau <marcandre.lureau@redhat.com>
Mon, 4 Dec 2023 07:28:26 +0000 (11:28 +0400)
commitebfbf394671163c14e2b24d98f3927a3151d1aff
tree4c3dae628c0400231e5327531775c3a41d26d0c1
parent53a939f1bf8e4a3e38f9449fac44f572676966ad
ui/vnc-clipboard: fix inflate_buffer

Commit d921fea338 ("ui/vnc-clipboard: fix infinite loop in
inflate_buffer (CVE-2023-3255)") removed this hunk, but it is still
required, because it can happen that stream.avail_in becomes zero
before coming across a return value of Z_STREAM_END in the loop.

This fixes the host->guest direction of the clipboard with noVNC and
TigerVNC as clients.

Fixes: d921fea338 ("ui/vnc-clipboard: fix infinite loop in inflate_buffer (CVE-2023-3255)")
Reported-by: Friedrich Weber <f.weber@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20231122125826.228189-1-f.ebner@proxmox.com>
ui/vnc-clipboard.c