]> git.proxmox.com Git - mirror_qemu.git/commit - ui/vnc.c
vnc: fix "info vnc" with "-vnc ..., reverse=on"
authorPaolo Bonzini <pbonzini@redhat.com>
Wed, 10 Oct 2012 12:30:58 +0000 (14:30 +0200)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 12 Oct 2012 08:55:37 +0000 (10:55 +0200)
commit417b0b88904fe1dd8c41bff8092dfbab0134d9cb
treee6848370d52ed500ae01feb5f8e9412b4d250470
parent2f5368017f8a0c00e982c3e315acb332a0907792
vnc: fix "info vnc" with "-vnc ..., reverse=on"

When reverse connection is in use, there is no active VNC server
socket.  Because of this, getsockopt(-1, ...) is attempted and
the following error is emitted:

    $ socat TCP-LISTEN:5900,reuseaddr TCP-LISTEN:5901,reuseaddr &
    $ x86_64-softmmu/qemu-system-x86_64 -vnc localhost:5900,reverse -monitor stdio
    QEMU 1.2.50 monitor - type 'help' for more information
    (qemu) info vnc
    An undefined error has occurred

Because however the host, family, service and auth fields are
optional, we can just exit if there is no active server socket.

    $ x86_64-softmmu/qemu-system-x86_64 -vnc localhost:5900,reverse -monitor stdio
    QEMU 1.2.50 monitor - type 'help' for more information
    (qemu) info vnc
    Server:
    Client:
         address: 127.0.0.1:5900
      x509_dname: none
        username: none

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
ui/vnc.c