]> git.proxmox.com Git - mirror_qemu.git/commit - util/thread-pool.c
thread-pool: avoid deadlock in nested aio_poll() calls
authorStefan Hajnoczi <stefanha@redhat.com>
Tue, 15 Jul 2014 14:44:26 +0000 (16:44 +0200)
committerKevin Wolf <kwolf@redhat.com>
Fri, 15 Aug 2014 13:07:14 +0000 (15:07 +0200)
commit3c80ca158c96ff902a30883a8933e755988948b1
treec1ccc27a2148e1173950d276838803bc5fafcec8
parentc2e50e3d11a0bf4c973cc30478c1af0f2d5f8e81
thread-pool: avoid deadlock in nested aio_poll() calls

The thread pool has a race condition if two elements complete before
thread_pool_completion_bh() runs:

  If element A's callback waits for element B using aio_poll() it will
  deadlock since pool->completion_bh is not marked scheduled when the
  nested aio_poll() runs.

Fix this by marking the BH scheduled while thread_pool_completion_bh()
is executing.  This way any nested aio_poll() loops will enter
thread_pool_completion_bh() and complete the remaining elements.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
thread-pool.c