]> git.proxmox.com Git - mirror_qemu.git/commit - vl.c
vl.c: move pidfile creation up the line
authorMichael Tokarev <mjt@tls.msk.ru>
Wed, 2 Nov 2016 14:18:50 +0000 (17:18 +0300)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 9 Nov 2016 13:08:17 +0000 (14:08 +0100)
commit004c8e0090025b4fde4e99fbc5a81049be8f79d1
tree75acefe8753f94a3e4f99b78448097994bb0c0a9
parentf5c052b973b0b2b3aa15e6cb0b0ac48ab763a9b0
vl.c: move pidfile creation up the line

With current code, pid file is open after various
sockets, chardevs, fsdevs and the like.  This causes
interesting effects, for example when monitor is a
unix-socket, and another qemu instance is already
running, new qemu first "damages" the socket and
next complain that it can't acquire the pid file and
exits, making running qemu unreachable.

Move pid file creation earlier, right after the call
to os_daemonize(), where we know our process id (pid).

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Message-Id: <1478096330-18081-1-git-send-email-mjt@msgid.tls.msk.ru>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
vl.c