]> git.proxmox.com Git - mirror_qemu.git/commit - vl.c
QemuOpts: Convert qemu_opt_set_bool() to Error, fix its use
authorMarkus Armbruster <armbru@redhat.com>
Thu, 12 Feb 2015 15:37:44 +0000 (16:37 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 26 Feb 2015 13:46:32 +0000 (14:46 +0100)
commitcccb7967bdf19f9d31e65d2d07d4d311e07545c4
tree1521f4b26e1615206e2e7ecbb29221099156a9dc
parentc5c6d7f81a6950d8e32a3b5a0bafd37bfa5a8e88
QemuOpts: Convert qemu_opt_set_bool() to Error, fix its use

Return the Error object instead of reporting it with
qerror_report_err().

Change callers that assume the function can't fail to pass
&error_abort, so that should the assumption ever break, it'll break
noisily.

Turns out all callers outside its unit test assume that.  We could
drop the Error ** argument, but that would make the interface less
regular, so don't.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
blockdev.c
include/qemu/option.h
tests/test-qemu-opts.c
util/qemu-option.c
util/qemu-sockets.c
vl.c