]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
USB: fix bug in initialization of interface minor numbers
authorAlan Stern <stern@rowland.harvard.edu>
Tue, 21 Sep 2010 19:01:53 +0000 (15:01 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 24 Sep 2010 18:05:00 +0000 (11:05 -0700)
commit0026e00523a85b90a92a93ddf6660939ecef3e54
treed618b4eb0948c061256346410a4107a526aaab40
parenta850ea30374ebed32a0724742601861853fde869
USB: fix bug in initialization of interface minor numbers

Recent changes in the usbhid layer exposed a bug in usbcore.  If
CONFIG_USB_DYNAMIC_MINORS is enabled then an interface may be assigned
a minor number of 0.  However interfaces that aren't registered as USB
class devices also have their minor number set to 0, during
initialization.  As a result usb_find_interface() may return the
wrong interface, leading to a crash.

This patch (as1418) fixes the problem by initializing every
interface's minor number to -1.  It also cleans up the
usb_register_dev() function, which besides being somewhat awkwardly
written, does not unwind completely on all its error paths.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Tested-by: Philip J. Turmel <philip@turmel.org>
Tested-by: Gabriel Craciunescu <nix.or.die@googlemail.com>
Tested-by: Alex Riesen <raa.lkml@gmail.com>
Tested-by: Matthias Bayer <jackdachef@gmail.com>
CC: Jiri Kosina <jkosina@suse.cz>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/core/file.c
drivers/usb/core/message.c