]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
tcp: fix tcp_fastopen unaligned access complaints on sparc
authorShannon Nelson <shannon.nelson@oracle.com>
Thu, 12 Jan 2017 22:24:58 +0000 (14:24 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 13 Jan 2017 17:31:24 +0000 (12:31 -0500)
commit003c941057eaa868ca6fedd29a274c863167230d
tree737b0e03c7e02fffc100298254a80e28d288d26d
parentfa79581ea66ca43d56ef065346ac5be767fcb418
tcp: fix tcp_fastopen unaligned access complaints on sparc

Fix up a data alignment issue on sparc by swapping the order
of the cookie byte array field with the length field in
struct tcp_fastopen_cookie, and making it a proper union
to clean up the typecasting.

This addresses log complaints like these:
    log_unaligned: 113 callbacks suppressed
    Kernel unaligned access at TPC[976490] tcp_try_fastopen+0x2d0/0x360
    Kernel unaligned access at TPC[9764ac] tcp_try_fastopen+0x2ec/0x360
    Kernel unaligned access at TPC[9764c8] tcp_try_fastopen+0x308/0x360
    Kernel unaligned access at TPC[9764e4] tcp_try_fastopen+0x324/0x360
    Kernel unaligned access at TPC[976490] tcp_try_fastopen+0x2d0/0x360

Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/tcp.h
net/ipv4/tcp_fastopen.c