]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
block: remove inaccurate requeue check
authorJens Axboe <axboe@kernel.dk>
Wed, 20 Oct 2021 14:21:40 +0000 (08:21 -0600)
committerAndrea Righi <andrea.righi@canonical.com>
Tue, 4 Jan 2022 08:48:16 +0000 (09:48 +0100)
commit009ed53f11fa0339d6d932ed8ef13af82f127ab6
tree9f88b85e5312bf205df84783fbfd144ecc70c3f8
parenta4ac6e1b1733ba7552a761f0cde91c4e6a5f5b23
block: remove inaccurate requeue check

BugLink: https://bugs.launchpad.net/bugs/1951822
[ Upstream commit 037057a5a979c7eeb2ee5d12cf4c24b805192c75 ]

This check is meant to catch cases where a requeue is attempted on a
request that is still inserted. It's never really been useful to catch any
misuse, and now it's actively wrong. Outside of that, this should not be a
BUG_ON() to begin with.

Remove the check as it's now causing active harm, as requeue off the plug
path will trigger it even though the request state is just fine.

Reported-by: Yi Zhang <yi.zhang@redhat.com>
Link: https://lore.kernel.org/linux-block/CAHj4cs80zAUc2grnCZ015-2Rvd-=gXRfB_dFKy=RTm+wRo09HQ@mail.gmail.com/
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
block/blk-mq.c