]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
powerpc/spufs: use struct_size() in kmalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 8 Jan 2019 18:37:20 +0000 (12:37 -0600)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 14 Jan 2019 09:39:27 +0000 (20:39 +1100)
commit00def7130af8b3fad1bdef98429c94a67dbbd896
treea93c381eec0e533e0040bedba62b7ba321be630f
parentfbe3ab014f37f67766e6cf5b0ce79d5e4197c536
powerpc/spufs: use struct_size() in kmalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = kmalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kmalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/platforms/cell/spufs/file.c