]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
fs: direct-io: fix missing sdio->boundary
authorJack Qiu <jack.qiu@huawei.com>
Fri, 9 Apr 2021 20:27:35 +0000 (13:27 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 7 May 2021 07:53:21 +0000 (09:53 +0200)
commit01a8b084955cf4cbb9101bfeff5b2c94fe49c28e
tree7fee243aaf21503a6659fcbf1a9db6dec9098ea5
parentf83eba50408f661a8e71bae2e04f2050ee2a4ebc
fs: direct-io: fix missing sdio->boundary

BugLink: https://bugs.launchpad.net/bugs/1926368
commit df41872b68601059dd4a84858952dcae58acd331 upstream.

I encountered a hung task issue, but not a performance one.  I run DIO
on a device (need lba continuous, for example open channel ssd), maybe
hungtask in below case:

  DIO: Checkpoint:
  get addr A(at boundary), merge into BIO,
  no submit because boundary missing
flush dirty data(get addr A+1), wait IO(A+1)
writeback timeout, because DIO(A) didn't submit
  get addr A+2 fail, because checkpoint is doing

dio_send_cur_page() may clear sdio->boundary, so prevent it from missing
a boundary.

Link: https://lkml.kernel.org/r/20210322042253.38312-1-jack.qiu@huawei.com
Fixes: b1058b981272 ("direct-io: submit bio after boundary buffer is added to it")
Signed-off-by: Jack Qiu <jack.qiu@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
fs/direct-io.c