]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
ceph: reuse request message when replaying against recovering mds
authorSage Weil <sage@newdream.net>
Thu, 15 Jul 2010 20:24:32 +0000 (13:24 -0700)
committerSage Weil <sage@newdream.net>
Fri, 16 Jul 2010 17:30:17 +0000 (10:30 -0700)
commit01a92f174f8a3b99dbb5e02c86e7ee1e576737af
treead478397d935b4b09340408cbacf8c6d35dee9d1
parentf91d3471ccf1ca9a795f46c94b1ded8dd219940c
ceph: reuse request message when replaying against recovering mds

Replayed rename operations (after an mds failure/recovery) were broken
because the request paths were regenerated from the dentry names, which
get mangled when d_move() is called.

Instead, resend the previous request message when replaying completed
operations.  Just make sure the REPLAY flag is set and the target ino is
filled in.

This fixes problems with workloads doing renames when the MDS restarts,
where the rename operation appears to succeed, but on mds restart then
fails (leading to client confusion, app breakage, etc.).

Signed-off-by: Sage Weil <sage@newdream.net>
fs/ceph/mds_client.c