]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
ASoC: dapm: Fix possible uninitialized variable in snd_soc_dapm_get_volsw()
authorChen-Yu Tsai <wens@csie.org>
Sat, 27 Aug 2016 11:27:58 +0000 (19:27 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 1 Sep 2016 20:05:18 +0000 (21:05 +0100)
commit01ad5e7de67b408d9b48b437b06a9938ddf460b5
tree141cab32d6e0b1c0b19d4f82c0ee6a907befc656
parent8053f21675b073b379cbca258ee4a3f3850dfa94
ASoC: dapm: Fix possible uninitialized variable in snd_soc_dapm_get_volsw()

If soc_dapm_read() fails, val will be uninitialized, and bogus values
will be written later:

ret = soc_dapm_read(dapm, reg, &val);
val = (val >> shift) & mask;

However, the compiler does not give a warning. Return on error before
val is really used to avoid this.

This is similar to the commit 6912831623c5 ("ASoC: dapm: Fix
uninitialized variable in snd_soc_dapm_get_enum_double()")

Fixes: ce0fc93ae56e (ASoC: Add DAPM support at the component level)
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-dapm.c