]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
squashfs: be more careful about metadata corruption
authorLinus Torvalds <torvalds@linux-foundation.org>
Sun, 29 Jul 2018 19:44:46 +0000 (12:44 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 29 Jul 2018 19:44:46 +0000 (12:44 -0700)
commit01cfb7937a9af2abb1136c7e89fbf3fd92952956
tree2b01fbc7eb315150d5a0ed71a218e4008801138b
parenta26fb01c2879ed7026e6cbd78bb701912d249eef
squashfs: be more careful about metadata corruption

Anatoly Trosinenko reports that a corrupted squashfs image can cause a
kernel oops.  It turns out that squashfs can end up being confused about
negative fragment lengths.

The regular squashfs_read_data() does check for negative lengths, but
squashfs_read_metadata() did not, and the fragment size code just
blindly trusted the on-disk value.  Fix both the fragment parsing and
the metadata reading code.

Reported-by: Anatoly Trosinenko <anatoly.trosinenko@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Phillip Lougher <phillip@squashfs.org.uk>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/squashfs/cache.c
fs/squashfs/file.c
fs/squashfs/fragment.c
fs/squashfs/squashfs_fs.h