]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
sctp: add vtag check in sctp_sf_ootb
authorXin Long <lucien.xin@gmail.com>
Wed, 20 Oct 2021 11:42:47 +0000 (07:42 -0400)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 24 Nov 2021 11:09:25 +0000 (12:09 +0100)
commit01e2274124b0beed07ed7342b2ca2357f2823d13
tree5600c783c3e8e64ad44914b98f1a2c9fa69b32ba
parentf9ddc0276f1b0d0895eae42f2960e91fee380097
sctp: add vtag check in sctp_sf_ootb

BugLink: https://bugs.launchpad.net/bugs/1951883
[ Upstream commit 9d02831e517aa36ee6bdb453a0eb47bd49923fe3 ]

sctp_sf_ootb() is called when processing DATA chunk in closed state,
and many other places are also using it.

The vtag in the chunk's sctphdr should be verified, otherwise, as
later in chunk length check, it may send abort with the existent
asoc's vtag, which can be exploited by one to cook a malicious
chunk to terminate a SCTP asoc.

When fails to verify the vtag from the chunk, this patch sets asoc
to NULL, so that the abort will be made with the vtag from the
received chunk later.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
net/sctp/sm_statefuns.c