]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
netfilter: conntrack: avoid use-after free on rmmod
authorFlorian Westphal <fw@strlen.de>
Fri, 3 Aug 2018 16:40:21 +0000 (18:40 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Fri, 3 Aug 2018 19:15:13 +0000 (21:15 +0200)
commit020f6cc5f75511c5974cfd454f224365bc0c2df4
treefb0bd60a7277c8c0445e67c6a9a8d914d2c9f39f
parent7bdfcea875ad42b6fd00413882fbc657c751f13a
netfilter: conntrack: avoid use-after free on rmmod

When the conntrack module is removed, we call nf_ct_iterate_destroy via
nf_ct_l4proto_unregister().

Problem is that nf_conntrack_proto_fini() gets called after the
conntrack hash table has already been freed.

Just remove the l4proto unregister call, its unecessary as the
nf_ct_protos[] array gets free'd right after anyway.

v2: add comment wrt. missing unreg call.

Fixes: a0ae2562c6c4b2 ("netfilter: conntrack: remove l3proto abstraction")
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_conntrack_proto.c