]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
blk-cgroup: Fix an RCU warning in blkiocg_create()
authorLi Zefan <lizf@cn.fujitsu.com>
Fri, 7 May 2010 06:57:00 +0000 (08:57 +0200)
committerJens Axboe <jens.axboe@oracle.com>
Fri, 7 May 2010 06:57:00 +0000 (08:57 +0200)
commit0341509fdfc9519f7de6aabc5dd23217cef72b73
tree84415f35129013b9d8fb3f5f0ef266437a02f09c
parentdcf097b247affd8b88ad410a92298590c5600f44
blk-cgroup: Fix an RCU warning in blkiocg_create()

with CONFIG_PROVE_RCU=y, a warning can be triggered:

  # mount -t cgroup -o blkio xxx /mnt
  # mkdir /mnt/subgroup

...
kernel/cgroup.c:4442 invoked rcu_dereference_check() without protection!
...

To fix this, we avoid caling css_depth() here, which is a bit simpler
than the original code.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
block/blk-cgroup.c