]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
USB: serial: keyspan_pda: add write-fifo support
authorJohan Hovold <johan@kernel.org>
Sun, 25 Oct 2020 17:45:56 +0000 (18:45 +0100)
committerJohan Hovold <johan@kernel.org>
Wed, 4 Nov 2020 10:01:44 +0000 (11:01 +0100)
commit034e38e8f68767fb5438ae3e608ee82919674177
treea9e029474e5578efe18a62ced0c7e3f9ac48755e
parent6fded8bcbc2e34d2267442376bf4fe9dde196d65
USB: serial: keyspan_pda: add write-fifo support

Use the port write fifo and generic chars_and_buffer and write_room
implementations when writing. This not only allows for more efficient
transfers, but more importantly fixes the remaining issues related to
the conservative write_room() implementation which could prevent the
line discipline from making forward progress (e.g. waiting for n > 1
bytes of space to become available).

Note that this also allows using the driver for the system console
without dropping data when the write URB is busy (including when adding
carriage return on line feed).

Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/keyspan_pda.c