]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
ptrace: Properly initialize ptracer_cred on fork
authorEric W. Biederman <ebiederm@xmission.com>
Mon, 22 May 2017 20:40:12 +0000 (15:40 -0500)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Tue, 27 Jun 2017 13:16:23 +0000 (10:16 -0300)
commit0394889d585fe142bf7730f69819145cef9ac633
tree5c77e178273bb65edd7bc9a94abbd347635ba059
parentadab163bb54a71bbf47fd445084e1d430e5995ce
ptrace: Properly initialize ptracer_cred on fork

BugLink: http://bugs.launchpad.net/bugs/1698799
commit c70d9d809fdeecedb96972457ee45c49a232d97f upstream.

When I introduced ptracer_cred I failed to consider the weirdness of
fork where the task_struct copies the old value by default.  This
winds up leaving ptracer_cred set even when a process forks and
the child process does not wind up being ptraced.

Because ptracer_cred is not set on non-ptraced processes whose
parents were ptraced this has broken the ability of the enlightenment
window manager to start setuid children.

Fix this by properly initializing ptracer_cred in ptrace_init_task

This must be done with a little bit of care to preserve the current value
of ptracer_cred when ptrace carries through fork.  Re-reading the
ptracer_cred from the ptracing process at this point is inconsistent
with how PT_PTRACE_CAP has been maintained all of these years.

Tested-by: Takashi Iwai <tiwai@suse.de>
Fixes: 64b875f7ac8a ("ptrace: Capture the ptracer's creds not PT_PTRACE_CAP")
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
include/linux/ptrace.h
kernel/ptrace.c