]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
nilfs2: fix use-after-free bug of struct nilfs_root
authorRyusuke Konishi <konishi.ryusuke@gmail.com>
Mon, 3 Oct 2022 15:05:19 +0000 (00:05 +0900)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 14 Nov 2022 10:25:46 +0000 (11:25 +0100)
commit03d0063d192abcd106611e8c68414be4d18d6341
tree3765b6904c232e98d475be31107df4a34f6b4d81
parent9f1985ceafccc06d636cc63504240753969c5173
nilfs2: fix use-after-free bug of struct nilfs_root

BugLink: https://bugs.launchpad.net/bugs/1995638
commit d325dc6eb763c10f591c239550b8c7e5466a5d09 upstream.

If the beginning of the inode bitmap area is corrupted on disk, an inode
with the same inode number as the root inode can be allocated and fail
soon after.  In this case, the subsequent call to nilfs_clear_inode() on
that bogus root inode will wrongly decrement the reference counter of
struct nilfs_root, and this will erroneously free struct nilfs_root,
causing kernel oopses.

This fixes the problem by changing nilfs_new_inode() to skip reserved
inode numbers while repairing the inode bitmap.

Link: https://lkml.kernel.org/r/20221003150519.39789-1-konishi.ryusuke@gmail.com
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Reported-by: syzbot+b8c672b0e22615c80fe0@syzkaller.appspotmail.com
Reported-by: Khalid Masum <khalid.masum.92@gmail.com>
Tested-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
fs/nilfs2/inode.c