]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ASoC: sgtl5000: Fix noise on shutdown/remove
authorFrancesco Dolcini <francesco.dolcini@toradex.com>
Fri, 24 Jun 2022 10:13:01 +0000 (12:13 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 7 Jul 2022 16:16:19 +0000 (17:16 +0100)
commit040e3360af3736348112d29425bf5d0be5b93115
treede686e50913562fbcb9dcd3d663e93cdb8802634
parent980555e95f7cabdc9c80a07107622b097ba23703
ASoC: sgtl5000: Fix noise on shutdown/remove

Put the SGTL5000 in a silent/safe state on shutdown/remove, this is
required since the SGTL5000 produces a constant noise on its output
after it is configured and its clock is removed. Without this change
this is happening every time the module is unbound/removed or from
reboot till the clock is enabled again.

The issue was experienced on both a Toradex Colibri/Apalis iMX6, but can
be easily reproduced everywhere just playing something on the codec and
after that removing/unbinding the driver.

Fixes: 9b34e6cc3bc2 ("ASoC: Add Freescale SGTL5000 codec support")
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Reviewed-by: Fabio Estevam <festevam@denx.de>
Link: https://lore.kernel.org/r/20220624101301.441314-1-francesco.dolcini@toradex.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/sgtl5000.c
sound/soc/codecs/sgtl5000.h