]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
libertas_tf: avoid a null dereference in pointer priv
authorColin Ian King <colin.king@canonical.com>
Fri, 1 May 2020 17:39:00 +0000 (18:39 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 6 May 2020 08:44:15 +0000 (11:44 +0300)
commit049ceac308b0d57c4f06b9fb957cdf95d315cf0b
tree0260f8ea02337eca39393f9874550f98c88fe5a2
parent08afb432c996e34e7047110a4d8c6979b8bd2b19
libertas_tf: avoid a null dereference in pointer priv

Currently there is a check if priv is null when calling lbtf_remove_card
but not in a previous call to if_usb_reset_dev that can also dereference
priv.  Fix this by also only calling lbtf_remove_card if priv is null.

It is noteable that there don't seem to be any bugs reported that the
null pointer dereference has ever occurred, so I'm not sure if the null
check is required, but since we're doing a null check anyway it should
be done for both function calls.

Addresses-Coverity: ("Dereference before null check")
Fixes: baa0280f08c7 ("libertas_tf: don't defer firmware loading until start()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200501173900.296658-1-colin.king@canonical.com
drivers/net/wireless/marvell/libertas_tf/if_usb.c